add rule for GetIsNetworkAvailable#1155
Merged
mike-hunhoff merged 5 commits intoMay 15, 2026
Merged
Conversation
mike-hunhoff
requested changes
May 13, 2026
Collaborator
mike-hunhoff
left a comment
mike-hunhoff
left a comment
There was a problem hiding this comment.
Thanks @omurcankaya , I left a quick suggestion for your review.
…ity-via-getisnetworkavailable-in-dotnet.yml Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
mike-hunhoff
requested changes
May 14, 2026
Collaborator
mike-hunhoff
left a comment
mike-hunhoff
left a comment
There was a problem hiding this comment.
@omurcankaya thank you, lints are now failing, and I added a couple of change comments that I missed the first time.
Collaborator
|
Ignore the CLA failure, I'll get that addressed on my end. Failing lint: |
…ity-via-getisnetworkavailable-in-dotnet.yml Co-authored-by: Mike Hunhoff <mike.hunhoff@gmail.com>
mike-hunhoff
approved these changes
May 15, 2026
Collaborator
|
The lints are still failing because of the rule name and filename do not match: Please address and ensure all lints are passing locally before requesting another review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1153